Skip to content

[framework] work around to load self packages from packages/ #111350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Sep 12, 2022
Merged

[framework] work around to load self packages from packages/ #111350

auto-submit merged 3 commits into from
Sep 12, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 10, 2022 •
edited
Loading

Restores removed feature that assets from the current package could still be loaded with a package prefix in unit tests. This change is designed to be cherry-picked, in the future we should make this more consistent.

Fixes #111285

FYI @andrewkolos

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 10, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 12, 2022
@jonahwilliams jonahwilliams marked this pull request as ready for review September 12, 2022 16:20
@jonahwilliams jonahwilliams mentioned this pull request Sep 12, 2022
Open
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2022
@auto-submit auto-submit bot merged commit cd83477 into flutter:master Sep 12, 2022
jonahwilliams pushed a commit to jonahwilliams/flutter that referenced this pull request Sep 12, 2022
[framework] work around to load self packages from packages/ (flutter…
1d3d082 
…#111350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
cd83477 [framework] work around to load self packages from packages/ (f…
978ea17 
…lutter/flutter#111350)
@jonahwilliams jonahwilliams deleted the restore_package_asset_loading branch September 12, 2022 19:25
itsjustkevin pushed a commit that referenced this pull request Sep 13, 2022
[framework] work around to load self packages from packages/ (#111350) (
5870540 
#111410)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
cd83477 [framework] work around to load self packages from packages/ (f…
de03db2 
…lutter/flutter#111350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
cd83477 [framework] work around to load self packages from packages/ (f…
b5cc585 
…lutter/flutter#111350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Asset bundle fails to load assets on tests in specific cases after 3.3.0

2 participants

@jonahwilliams @dnfield