Roll Flutter Engine from f72107f4576d to 0b6dcd86bb1b (3 revisions) #111330
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@yjbanov Are the Skia diffs from the CanvasKit roll? |
Yes. CanvasKit 0.37.0 includes this change, which has an effect on text rendering at the edges. It is also expected to deflake text rendering, according to Skia's own golden tests:
I triaged the diffs as positive. |
|
It looks like FRoB testing is stuck. I am going to land this manually. cc @godofredoc for a situation where it looks like the sheriff would need break-glass permissions. |
flutter/engine@f72107f...0b6dcd8
2022-09-10 bdero@google.com [Impeller] Premultiply gradient alpha after the gradient LUT is generated (flutter/engine#36064)
2022-09-10 jason-simmons@users.noreply.github.com Populate dart_library_sources_kernel in the embedder library in JIT mode (flutter/engine#36059)
2022-09-10 yjbanov@google.com [web] roll CanvasKit 0.37.0 (flutter/engine#36011)
Also rolling transitive DEPS:
flutter/web/canvaskit_bundle from 8wh6J7ZXGCgo to C478RsheZD4F
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md