This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Premultiply gradient alpha after the gradient LUT is generated #36064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Contributor
|
I think you need to delete the premultiply here: https://github.com/flutter/engine/blob/main/impeller/geometry/gradient.cc#L12 (and update corresponding tests) |
Member
Author
|
Indeed, this looks good now: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2022
…111330) * 7abd89c90 [web] roll CanvasKit 0.37.0 (flutter/engine#36011) * dae737f46 Populate dart_library_sources_kernel in the embedder library in JIT mode (flutter/engine#36059) * 0b6dcd86b [Impeller] Premultiply gradient alpha after the gradient LUT is generated (flutter/engine#36064)
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All output from the fragment stage must be premultiplied.
It looks like somewhere along the way we lost the premultiply for the gradients.