Skip to content

Replace ListTile with Chip in the debugCheckHasMaterial control test #102311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 21, 2022
Merged

Replace ListTile with Chip in the debugCheckHasMaterial control test #102311

fluttergithubbot merged 1 commit into from
Apr 21, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 21, 2022 •
edited by gspencergoog
Loading

fixes #102308

#102310 is adding self-contained Material to list_tile.dart to fix multiple ListTile issues.
As a result, ListTile is no longer suitable for this test, as this test needs a widget that needs to be provided Material as one of the ancestors

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2022
@TahaTesser
Copy link
Member Author

TahaTesser commented Apr 21, 2022 •
edited
Loading

This needs to be landed for #102310

This was referenced Apr 21, 2022
Merged
Closed
@TahaTesser TahaTesser changed the title Replace ListTile with Chip in the 'debugCheckHasMaterial control test' Replace ListTile with Chip in the debugCheckHasMaterial control test Apr 21, 2022
@TahaTesser TahaTesser requested a review from gspencergoog April 21, 2022 18:46
gspencergoog
gspencergoog approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 900e540 into flutter:master Apr 21, 2022
@TahaTesser TahaTesser deleted the update_debug_material_test branch April 21, 2022 20:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
4683435 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
b6a0342 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
b9be745 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
5105b85 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
2d3750b 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
dc1628b 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
982292b 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
c7ebdb8 
…control test` (flutter/flutter#102311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
9c218f6 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
3923def 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
de8c193 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
b21d7f9 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
c5d25cb 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
c736563 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
71eb20d 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
957e884 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
5aff034 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
0d73b6c 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
6986c27 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
f9cf294 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
80698bd 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
c5af9ee 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
37af9c5 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
66c80d5 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
f008601 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
7196bce 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
2935522 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
e3489d1 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
36afb8f 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
1b6af0c 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
f0f58e1 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
fcc7192 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
d5459d6 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
2818607 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
b034c2a 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
330285d 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
7c3ea5b 
…control test` (flutter/flutter#102311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
900e540 Replace ListTile with Chip in the `debugCheckHasMaterial …
a432e21 
…control test` (flutter/flutter#102311)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
Replace ListTile with Chip in the `debugCheckHasMaterial control …
641fa7c 
…test` (flutter#102311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace ListTile with Chip in the material/debug_test.dart

3 participants

@TahaTesser @gspencergoog @fluttergithubbot