-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
#102310 is adding self-contained Material to list_tile.dart to fix multiple ListTile issues.
As a result, ListTile is no longer suitable for this test, as this test needs a widget that needs to be provided Material as one of the ancestors
flutter/packages/flutter/test/material/debug_test.dart
Lines 10 to 24 in c910d8d
| testWidgets('debugCheckHasMaterial control test', (WidgetTester tester) async { | |
| await tester.pumpWidget(const ListTile()); | |
| final dynamic exception = tester.takeException(); | |
| expect(exception, isFlutterError); | |
| final FlutterError error = exception as FlutterError; | |
| expect(error.diagnostics.length, 5); | |
| expect(error.diagnostics[2].level, DiagnosticLevel.hint); | |
| expect( | |
| error.diagnostics[2].toStringDeep(), | |
| equalsIgnoringHashCodes( | |
| 'To introduce a Material widget, you can either directly include\n' | |
| 'one, or use a widget that contains Material itself, such as a\n' | |
| 'Card, Dialog, Drawer, or Scaffold.\n', | |
| ), | |
| ); |
Solution
Replace ListTile with Chip as it needs a Material ancestor.
| assert(debugCheckHasMaterial(context)); |
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Type
Projects
Status
Done (PR merged)