This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix missing assignment to _allowHeadlessExecution #9855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 16, 2019
stuartmorgan-g
approved these changes
Jul 16, 2019
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Ugh, thanks for the fix. Sometime soon I need to get unit tests on these APIs.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2019
flutter/engine@eb248c2...8849d30 git log eb248c2..8849d30 --no-merges --oneline 8849d30 Add multi-line flag to semantics (flutter/engine#9850) 91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883) 3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885) cd321ee Assign missing headless execution variable (flutter/engine#9855) 3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882) 9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@eb248c2...8849d30 git log eb248c2..8849d30 --no-merges --oneline 8849d30 Add multi-line flag to semantics (flutter/engine#9850) 91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883) 3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885) cd321ee Assign missing headless execution variable (flutter/engine#9855) 3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882) 9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.