Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jul 16, 2019

This flag is currently only used in the web engine to decide whether to create an <input> or <textarea> element.

Related to the flutter PR: flutter/flutter#36297

Fixes flutter/flutter#34265

@yjbanov
Copy link
Contributor

yjbanov commented Jul 16, 2019

lgtm

@mdebbar mdebbar merged commit 8849d30 into flutter:master Jul 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 17, 2019
flutter/engine@eb248c2...8849d30

git log eb248c2..8849d30 --no-merges --oneline
8849d30 Add multi-line flag to semantics (flutter/engine#9850)
91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883)
3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885)
cd321ee Assign missing headless execution variable (flutter/engine#9855)
3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882)
9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@eb248c2...8849d30

git log eb248c2..8849d30 --no-merges --oneline
8849d30 Add multi-line flag to semantics (flutter/engine#9850)
91e7a76 Roll src/third_party/dart 24725a8559..2b3336b51e (108 commits) (flutter/engine#9883)
3cd3e5e Roll fuchsia/sdk/core/mac-amd64 from x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C to PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C (flutter/engine#9885)
cd321ee Assign missing headless execution variable (flutter/engine#9855)
3186ffe Roll src/third_party/skia 63fdd0191be0..e574f1e409aa (1 commits) (flutter/engine#9882)
9c9daa0 Roll fuchsia/sdk/core/mac-amd64 from f97PVV8BR3sa4rxRIc-xgvBxd6HYa8mKNp8zGmqqx-UC to x0S8o-I3LOxltQzGPHsScGKtGALS89j7LYlSANNF-T8C (flutter/engine#9881)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop
the roller if necessary.
@mdebbar mdebbar deleted the semantics_multiline branch April 15, 2021 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web][upstream] In semantics upstream isMultiline

3 participants