Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@ojhunt
Copy link
Contributor

@ojhunt ojhunt commented Jun 17, 2019

Bug: SEC-314

Just adding this feature as a pre-flight step while we
restrict the ability for arbitrary processes to make
VMOs executable.

Bug: SEC-314

dding this feature all fuchsia components as a pre-flight step
as we restrict the ability for arbitrary processes to make
VMOs executable.
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 05c034e into flutter:master Jun 18, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 18, 2019
flutter/engine@20d3861...05c034e

git log 20d3861..05c034e --no-merges --oneline
05c034e Update component manifests for ambient replace-as-executable (flutter/engine#9350)
66022ce Roll src/third_party/skia 55091020435c..4b203ad7ac02 (6 commits) (flutter/engine#9352)
fcff2d6 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337)
ea7ca98 Send the isolate service ID from the engine to the embedder (flutter/engine#9324)
675033f Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322)
e5918d1 Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348)
e00ac47 Reorganize darwin for shared ios/macOS (flutter/engine#9255)
9da409c Fix crash on Huawei device with AndroidView (flutter/engine#9192)
a0f8554 Removed an unused class definition for iOS code. (flutter/engine#9346)
96a1a84 Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@20d3861...05c034e

git log 20d3861..05c034e --no-merges --oneline
05c034e Update component manifests for ambient replace-as-executable (flutter/engine#9350)
66022ce Roll src/third_party/skia 55091020435c..4b203ad7ac02 (6 commits) (flutter/engine#9352)
fcff2d6 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337)
ea7ca98 Send the isolate service ID from the engine to the embedder (flutter/engine#9324)
675033f Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322)
e5918d1 Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348)
e00ac47 Reorganize darwin for shared ios/macOS (flutter/engine#9255)
9da409c Fix crash on Huawei device with AndroidView (flutter/engine#9192)
a0f8554 Removed an unused class definition for iOS code. (flutter/engine#9346)
96a1a84 Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants