This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Check for invalid indexes when performing InputAdpator backspace. #9322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am currently in need of a repro of the bug to ensure this does what I intend it to do. |
Contributor
Author
|
@justinmc for repro |
Contributor
|
I couldn't reproduce this with a quick try on 2 phones lying around, but tomorrow I'll try again with the Samsung phone that I got it on before. |
Contributor
|
Sorry, going to try this again on Monday. I have the Samsung phone but I can't get the engine to compile for it on my Mac :( |
Contributor
Author
|
I just managed to repro the crash with an arabic keyboard I can continue with this now! Thanks for trying though! |
Contributor
|
Ah good, no problem! |
Contributor
Author
|
After exploring this more, this will need additional work to handle RTL, as well as other indexing issues. |
Contributor
Author
|
This resolves the crash portion of backspacing in Chinese and some RTL keyboards, but I have discovered some (existing, non-crashing) incompatibility when backspacing using the chinese keyboard on mixed RTL/LTR text. I will resolve that behavior in a separate PR. This change should not cause any behavior regressions other than eliminating crashes. |
justinmc
approved these changes
Jun 17, 2019
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Do we have a way to log a warning when the index is out of bounds in clampIndexToEditable? I just figure we might want to know if that happens since it could indicate a bug elsewhere, even if this is able to recover.
shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Fixes flutter/flutter#33642 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 18, 2019
flutter/engine@20d3861...05c034e git log 20d3861..05c034e --no-merges --oneline 05c034e Update component manifests for ambient replace-as-executable (flutter/engine#9350) 66022ce Roll src/third_party/skia 55091020435c..4b203ad7ac02 (6 commits) (flutter/engine#9352) fcff2d6 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337) ea7ca98 Send the isolate service ID from the engine to the embedder (flutter/engine#9324) 675033f Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322) e5918d1 Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348) e00ac47 Reorganize darwin for shared ios/macOS (flutter/engine#9255) 9da409c Fix crash on Huawei device with AndroidView (flutter/engine#9192) a0f8554 Removed an unused class definition for iOS code. (flutter/engine#9346) 96a1a84 Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
This was referenced Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2019
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@20d3861...05c034e git log 20d3861..05c034e --no-merges --oneline 05c034e Update component manifests for ambient replace-as-executable (flutter/engine#9350) 66022ce Roll src/third_party/skia 55091020435c..4b203ad7ac02 (6 commits) (flutter/engine#9352) fcff2d6 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337) ea7ca98 Send the isolate service ID from the engine to the embedder (flutter/engine#9324) 675033f Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322) e5918d1 Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348) e00ac47 Reorganize darwin for shared ios/macOS (flutter/engine#9255) 9da409c Fix crash on Huawei device with AndroidView (flutter/engine#9192) a0f8554 Removed an unused class definition for iOS code. (flutter/engine#9346) 96a1a84 Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection.getSelectionStartcan return -1, which causes an index out of bounds. In the case of a invalid deletion, unspecifiable selections will not be deleted.b/135036951
Fixes flutter/flutter#33642