This repository was archived by the owner on Feb 25, 2025. It is now read-only.
libtxt: add a BoxHeightStyle option based on the height of the strut #8927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you add a test in paragraph_unittests that verifies this behavior alongside the tests for each other mode? |
GaryQian
reviewed
May 9, 2019
| /// {@macro flutter.dart:ui.boxHeightStyle.includeLineSpacing} | ||
| includeLineSpacingBottom, | ||
|
|
||
| /// Calculate box heights based on the metrics of this paragraph's [StrutStyle]. |
Contributor
There was a problem hiding this comment.
This could use a bit more detail about the properties of this, such as each box will have the same height, and the top/bottoms of the boxes will line up with each other.
GaryQian
reviewed
May 9, 2019
| // The line spacing will be added to the bottom of the rect. | ||
| kIncludeLineSpacingBottom | ||
| kIncludeLineSpacingBottom, | ||
|
|
Contributor
There was a problem hiding this comment.
extra space? not consistent with rest of the code.
Member
Author
There was a problem hiding this comment.
This is intended to separate kStrut from the group of kIncludeLine values
Member
Author
|
Added a test - PTAL |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 16, 2019
flutter/engine@288a855...9d7cd70 git log 288a855..9d7cd70 --no-merges --oneline 9d7cd70 add observatoryUrl property to FlutterEngine (flutter/engine#8987) 34a5248 Add matrix4 param to Linear gradients (flutter/engine#8985) aa63f09 libtxt: add a BoxHeightStyle option based on the height of the strut (flutter/engine#8927) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flutter/flutter#32332