This repository was archived by the owner on Feb 25, 2025. It is now read-only.
remove legacy build deps #8820
Merged
remove legacy build deps #8820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 2, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2019
| "//third_party/android_support/android_support_annotations.jar", | ||
| "//third_party/android_support/android_support_fragment.jar", | ||
| "//third_party/android_support/android_arch_lifecycle_common.jar", | ||
| "//third_party/android_support/android_arch_lifecycle_viewmodel.jar", |
Contributor
There was a problem hiding this comment.
@dnfield do we know who is using this? The lifecycle_common is needed for the new plugin API proposal, but I don't think lifecycle_viewmodel is required for that purpose. I wasn't sure if someone else was using it for something.
Contributor
Author
There was a problem hiding this comment.
These are used by the embedding since the roll to sdk 28
Contributor
Author
There was a problem hiding this comment.
I'm not sure exactly which classes consume them - some of them are transitive deps as well. But if you remove any javac will fail.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 3, 2019
flutter/engine@ef2bed6...39a950e git log ef2bed6..39a950e --no-merges --oneline 39a950e remove legacy build deps (flutter/engine#8820) c0be4e2 Fix api conformance check (flutter/engine#8817) 30639ee Allow FlutterEngine to be used on back-to-back screens (#31264). (flutter/engine#8808) 45d0c4d Roll src/third_party/skia cd5d14619fe2..68eb8c276355 (4 commits) (flutter/engine#8815) 9856479 Roll src/third_party/dart b6997deb3e..1577b95c93 (18 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of flutter/flutter#17780
This removes the dependencies on the Chromium java_library templates.
This will also help address flutter/flutter#31928, where I want to generate some new Java code via GN to make the build mode available in the Java embedding