Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

returning an int is not the same as calling exit

@jonahwilliams jonahwilliams requested a review from dnfield May 2, 2019 20:30
@jonahwilliams
Copy link
Contributor Author

cc @justinmc @HansMuller

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit c0be4e2 into flutter:master May 2, 2019
@jonahwilliams jonahwilliams deleted the roll_web_ui branch May 2, 2019 21:11
@Hixie
Copy link
Contributor

Hixie commented May 2, 2019

While we're here:

  • "Warning" should be "Error" in this script (when it prints messages about failures).
  • Could we remove all the dartdocs from the stub_ui code? It's bound to get out of date and as far as I can tell we don't use it. If not, we should make the script verify that they're identical.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request May 3, 2019
flutter/engine@ef2bed6...39a950e

git log ef2bed6..39a950e --no-merges --oneline
39a950e remove legacy build deps (flutter/engine#8820)
c0be4e2 Fix api conformance check (flutter/engine#8817)
30639ee Allow FlutterEngine to be used on back-to-back screens (#31264). (flutter/engine#8808)
45d0c4d Roll src/third_party/skia cd5d14619fe2..68eb8c276355 (4 commits) (flutter/engine#8815)
9856479 Roll src/third_party/dart b6997deb3e..1577b95c93 (18 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants