Add windows host_debug_unopt build test #8515
Conversation
85202d6 to
fa4850d
Compare
|
@cbracken @chinmaygarde : although we're going to retire |
|
I believe |
|
@dnfield I can only find "build host_dynamic_release" in https://ci.chromium.org/p/flutter/builders/prod/Windows%20Host%20Engine/232 . There seems to be no "build host_release" . |
|
Ohhh! I don't think we can build an AOT mode engine on Windows right now. Dynamic isn't AOT mode. |
|
@dnfield so do we still need to compile and test the release build on windows? |
fa4850d to
d9a09f4
Compare
|
Talked offline - I don't think we need this in presubmit. If we had any tests running for it that'd be nice, but we build it in post submit and really just to verify that it builds. It doesn't seem likely to add much value in presubmit. |
|
@dnfield I'll only test debug and debug_unopt (mainly to ensure that debug_unopt can won't regress in non-Google windows environment) then. Does it look good to you? |
flutter/engine@eec74e5...905c571 git log eec74e5..905c571 --no-merges --oneline 905c571 Add windows host_debug_unopt build (flutter/engine#8515) 39e1d00 Remove redundant specification of the |flutter| namespace in the engine. (flutter/engine#8523) 56052c7 Rename the shell namespace to flutter. (flutter/engine#8520) ca1d163 Support message loops whose tasks are executed concurrently. (flutter/engine#8419) 8ae84ec Roll src/third_party/skia de8362c6f212..10bf7020aa15 (5 commits) (flutter/engine#8522) 2dbd981 Roll src/third_party/dart 06ed3f598c..1490a90bc1 (8 commits) 5279132 Android Embedding PR27: Fix SurfaceView flicker in Fragment transactions (flutter/engine#8504) 86ab45c Remove the unused EnableBlink flag. (flutter/engine#8518) d5880a6 Roll src/third_party/skia b5d8c634f95b..de8362c6f212 (14 commits) (flutter/engine#8519) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
The issue with
gn --unoptimizedseems to be solved in the ToT engine, buildroot, or depot_tools.The added test makes sure that it won't be broken again for non-Google windows machines.