This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support message loops whose tasks are executed concurrently. #8419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of workers depends on what the platform deem appropriate for the system at runtime.
Contributor
Author
|
This is WIP and prototypes the necessary infrastructure for supporting use cases like concurrent resource fetches. |
Contributor
Author
|
I got rid of the platform specific concurrent message loop in favor of one using condition variables and a mutex. |
Contributor
Author
|
Investigating why the tests are failing. The same pass on Mac. |
Contributor
Author
|
Addressed early shutdown. |
Member
|
/cc @jason-simmons |
Contributor
Author
|
Ping. This is good to go. |
cbracken
approved these changes
Apr 9, 2019
| FML_EMBEDDER_ONLY | ||
| static MessageLoop& GetCurrent(); | ||
|
|
||
| enum class Type { kConcurrent }; |
Member
There was a problem hiding this comment.
Consider adding an enum value for the default type (kSerial?)
Contributor
Author
There was a problem hiding this comment.
Those are regular message loops that need to be explicitly run. I don't components to be able to start those up explicitly.
Contributor
Author
There was a problem hiding this comment.
The ability to create a serial queue is present but that is the default with the no-argument constructor which is private.
| } | ||
|
|
||
| MessageLoop::MessageLoop(Type) | ||
| : loop_(fml::MakeRefCounted<ConcurrentMessageLoop>()), |
Member
There was a problem hiding this comment.
Support both types here. See comment in header.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2019
flutter/engine@eec74e5...905c571 git log eec74e5..905c571 --no-merges --oneline 905c571 Add windows host_debug_unopt build (flutter/engine#8515) 39e1d00 Remove redundant specification of the |flutter| namespace in the engine. (flutter/engine#8523) 56052c7 Rename the shell namespace to flutter. (flutter/engine#8520) ca1d163 Support message loops whose tasks are executed concurrently. (flutter/engine#8419) 8ae84ec Roll src/third_party/skia de8362c6f212..10bf7020aa15 (5 commits) (flutter/engine#8522) 2dbd981 Roll src/third_party/dart 06ed3f598c..1490a90bc1 (8 commits) 5279132 Android Embedding PR27: Fix SurfaceView flicker in Fragment transactions (flutter/engine#8504) 86ab45c Remove the unused EnableBlink flag. (flutter/engine#8518) d5880a6 Roll src/third_party/skia b5d8c634f95b..de8362c6f212 (14 commits) (flutter/engine#8519) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of workers depends on what the platform deem appropriate for the system at runtime.