This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts #55932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#55932) This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change. Bug: http://b/353729557, http://b/368608542 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
55d39c8 to
1cd59a0
Compare
jacobsimionato
approved these changes
Oct 21, 2024
jacobsimionato
left a comment
There was a problem hiding this comment.
LGTM for the fix for google3 compatibility. I don't work on Fuchsia, so I don't understand the context of the underlying CL, but I see #55832 was already fully reviewed and this is only a slight tweak.
Thanks so much for verifying this in google3 first. It's much appreciated! We'll watch this roll in over the next day or two.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
Author
|
Thank you Jacob. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 22, 2024
flutter/engine@d302cc9...b3e227b 2024-10-22 devoncarew@google.com update the SoT location for package:http_parser (flutter/engine#55998) 2024-10-21 6844906+zijiehe-google-com@users.noreply.github.com Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55932) 2024-10-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 10387c3fc6d4 to 86ac62245577 (1 revision) (flutter/engine#55995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ngine#55932) Redo: flutter/engine#55832 See the diff of diffs, ``` diff <(curl -s 'https://github.com/flutter/engine/commit/1cd59a0c069a2436185b7009fa279afdb3b014cb.diff') <(curl -s 'https://github.com/flutter/engine/commit/ccea3b80cc162070b9e1197966772fd1c3843925.diff') ``` Or ``` 48c48 < index 5258466..83aebdaacd9b6 100755 --- > index 5258466..3f74d19 100755 141,142c141,142 < + far_file = '%s_%s%s_runner-0.far' % (runner_type, mode, '_product' if product else '') < + CopyPath('%s/%s' % (source_root, far_file), '%s/%s' % (destination, far_file)) --- > + far_file = '%s_%s%s_runner' % (runner_type, mode, '_product' if product else '') > + CopyPath('%s/%s-0.far' % (source_root, far_file), '%s/%s.far' % (destination, far_file)) ``` This change restores the files' -0 suffix which was wrongly removed in the last iteration. === Description of the original change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. flutter/engine#55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo: #55832
See the diff of diffs,
Or
This change restores the files' -0 suffix which was wrongly removed in the last iteration.
=== Description of the original change:
This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk.
Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed.
#55445 was a previous attempt and it generates a malformatted cipd.
Bug: http://b/353729557, http://b/368608542
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.