[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

zijiehe-google-com · 2024-10-11T17:35:36Z

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk.

Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed.
#55445 was a previous attempt and it generates a malformatted cipd.

Bug: http://b/353729557, http://b/368608542

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change. Bug: http://b/353729557, http://b/368608542 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

flutter-dashboard · 2024-10-11T18:40:46Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

jrwang

LGTM

zijiehe-google-com · 2024-10-16T17:27:24Z

Thank you. I will page the roller gardener about this change in case anything goes wrong as the previous attempt.

…ngine#55832)

flutter/engine@4d4f7d8...f6fd2cb 2024-10-16 skia-flutter-autoroll@skia.org Roll Skia from 69d9d593a095 to 09917e06158b (1 revision) (flutter/engine#55907) 2024-10-16 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

auto-submit · 2024-10-17T01:05:35Z

A reason for requesting a revert of flutter/engine/55832 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

zijiehe-google-com · 2024-10-17T01:07:20Z

Reason for revert: may break roller.

This reverts commit 97c7de3.

…#55922) Reverts: #55832 Initiated by: zijiehe-google-com Reason for reverting: may break roller. Original PR Author: zijiehe-google-com Reviewed By: {jrwang} This change reverts the following previous change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. #55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…7054) flutter/engine@4d4f7d8...f6fd2cb 2024-10-16 skia-flutter-autoroll@skia.org Roll Skia from 69d9d593a095 to 09917e06158b (1 revision) (flutter/engine#55907) 2024-10-16 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Redo: #55832 See the diff of diffs, ``` diff <(curl -s 'https://github.com/flutter/engine/commit/1cd59a0c069a2436185b7009fa279afdb3b014cb.diff') <(curl -s 'https://github.com/flutter/engine/commit/97c7de37bccde02a8997f8f94ad9ea6527a0c18b.diff') ``` Or ``` 48c48 < index 5258466..83aebda 100755 --- > index 5258466..3f74d19 100755 141,142c141,142 < + far_file = '%s_%s%s_runner-0.far' % (runner_type, mode, '_product' if product else '') < + CopyPath('%s/%s' % (source_root, far_file), '%s/%s' % (destination, far_file)) --- > + far_file = '%s_%s%s_runner' % (runner_type, mode, '_product' if product else '') > + CopyPath('%s/%s-0.far' % (source_root, far_file), '%s/%s.far' % (destination, far_file)) ``` This change restores the files' -0 suffix which was wrongly removed in the last iteration. === Description of the original change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. #55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

) This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. flutter/engine#55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…55832)" (flutter/engine#55922) Reverts: flutter/engine#55832 Initiated by: zijiehe-google-com Reason for reverting: may break roller. Original PR Author: zijiehe-google-com Reviewed By: {jrwang} This change reverts the following previous change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. flutter/engine#55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…ngine#55932) Redo: flutter/engine#55832 See the diff of diffs, ``` diff <(curl -s 'https://github.com/flutter/engine/commit/1cd59a0c069a2436185b7009fa279afdb3b014cb.diff') <(curl -s 'https://github.com/flutter/engine/commit/ccea3b80cc162070b9e1197966772fd1c3843925.diff') ``` Or ``` 48c48 < index 5258466..83aebdaacd9b6 100755 --- > index 5258466..3f74d19 100755 141,142c141,142 < + far_file = '%s_%s%s_runner-0.far' % (runner_type, mode, '_product' if product else '') < + CopyPath('%s/%s' % (source_root, far_file), '%s/%s' % (destination, far_file)) --- > + far_file = '%s_%s%s_runner' % (runner_type, mode, '_product' if product else '') > + CopyPath('%s/%s-0.far' % (source_root, far_file), '%s/%s.far' % (destination, far_file)) ``` This change restores the files' -0 suffix which was wrongly removed in the last iteration. === Description of the original change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. flutter/engine#55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

zijiehe-google-com and others added 6 commits October 11, 2024 10:33

remove

fda94f6

format

a9e279a

Merge branch 'flutter:main' into main

39adcb9

Merge branch 'main' into main

4b4f65e

github-actions bot added the platform-fuchsia label Oct 11, 2024

zijiehe-google-com added 2 commits October 11, 2024 11:11

remove todo

571b854

prod

6939c02

zijiehe-google-com marked this pull request as ready for review October 11, 2024 18:39

zijiehe-google-com requested review from jrwang and zanderso October 11, 2024 18:39

zijiehe-google-com and others added 5 commits October 11, 2024 11:54

remove unused functions

8cce0f2

Merge branch 'main' into main

27a75fb

Merge branch 'main' into main

31b0ff6

Merge branch 'main' into main

db60118

Merge branch 'main' into main

1c33297

jrwang approved these changes Oct 16, 2024

View reviewed changes

Merge branch 'main' into main

1b74a59

zijiehe-google-com added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024

auto-submit bot merged commit 97c7de3 into flutter:main Oct 16, 2024

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Roll Flutter Engine from 4d4f7d8094b4 to 97c7de37bccd (1 revision) flutter/flutter#157035

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024

97c7de3 [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/e…

737de21

…ngine#55832)

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Roll Flutter Engine from 4d4f7d8094b4 to f6fd2cbe4773 (2 revisions) flutter/flutter#157054

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2024

97c7de3 [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/e…

a510d9f

…ngine#55832)

zijiehe-google-com added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2024

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2024

zijiehe-google-com added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2024

auto-submit bot pushed a commit that referenced this pull request Oct 17, 2024

Revert "[fuchsia] Remove pm use in build_fuchsia_artifacts (#55832)"

6c876e9

This reverts commit 97c7de3.

auto-submit bot mentioned this pull request Oct 17, 2024

Reverts "[fuchsia] Remove pm use in build_fuchsia_artifacts (#55832)" #55922

Merged

8 tasks

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2024

zijiehe-google-com mentioned this pull request Oct 17, 2024

Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts #55932

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

Uh oh!

zijiehe-google-com commented Oct 11, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 11, 2024

Uh oh!

jrwang left a comment

Uh oh!

zijiehe-google-com commented Oct 16, 2024

Uh oh!

auto-submit bot commented Oct 17, 2024

Uh oh!

zijiehe-google-com commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

Uh oh!

Conversation

zijiehe-google-com commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Oct 11, 2024

Uh oh!

jrwang left a comment

Choose a reason for hiding this comment

Uh oh!

zijiehe-google-com commented Oct 16, 2024

Uh oh!

auto-submit bot commented Oct 17, 2024

Uh oh!

zijiehe-google-com commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zijiehe-google-com commented Oct 11, 2024 •

edited

Loading