This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] make Platform thread the UI thread for iOS Impeller. #54655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
jonahwilliams
commented
Aug 20, 2024
| IOSPlatformThreadConfigSetter); | ||
|
|
||
| if (!settings.merged_platform_ui_thread) { | ||
| if (!settings.enable_impeller) { |
Contributor
Author
There was a problem hiding this comment.
Important: on iOS this thread mode is guarded by Impeller usage.
Contributor
Author
|
For googlers, we're currently running a TGP on this change in google3 (see cl/665573552) |
Contributor
Author
|
Looks like some failures in g3. For now I'm going to do this for iOS/Impeller only. |
473adfb to
325268e
Compare
johnmccutchan
approved these changes
Aug 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2024
flutter/engine@41f539f...ba1168f 2024-08-23 jonahwilliams@google.com [Engine] Add no op surface (flutter/engine#54694) 2024-08-23 jonahwilliams@google.com [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655) 2024-08-23 mdebbar@google.com [web] Multi-view support for Skwasm (flutter/engine#48893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…4020) flutter/engine@41f539f...ba1168f 2024-08-23 jonahwilliams@google.com [Engine] Add no op surface (flutter/engine#54694) 2024-08-23 jonahwilliams@google.com [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655) 2024-08-23 mdebbar@google.com [web] Multi-view support for Skwasm (flutter/engine#48893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it blend?