[web] Multi-view support for Skwasm #48893
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@mdebbar is this ready for review and I've been blocking it for a while now? |
Nah, I'm self-blocked lol. I want to write tests before I submit this PR. (don't mind the merge commits being pushed, I'm just resolving merge conflicts with |
|
Can we make this a Draft PR for now then? |
|
(triage) I spoke to @mdebbar last week and they said this is still on their radar. |
a7b2f37 to
7b8fffb
Compare
eb41d85 to
37a8ef6
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
flutter/engine@41f539f...ba1168f 2024-08-23 jonahwilliams@google.com [Engine] Add no op surface (flutter/engine#54694) 2024-08-23 jonahwilliams@google.com [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655) 2024-08-23 mdebbar@google.com [web] Multi-view support for Skwasm (flutter/engine#48893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…4020) flutter/engine@41f539f...ba1168f 2024-08-23 jonahwilliams@google.com [Engine] Add no op surface (flutter/engine#54694) 2024-08-23 jonahwilliams@google.com [engine] make Platform thread the UI thread for iOS Impeller. (flutter/engine#54655) 2024-08-23 mdebbar@google.com [web] Multi-view support for Skwasm (flutter/engine#48893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Wow, yes! |
Support multi-view mode in the Skwasm renderer.
Fixes flutter/flutter#138925