This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update package:js version constraints to ^0.7.0 and update test versions to match #54629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dependency on dart:js and allows that library to be removed from dart2wasm.
Member
|
When I tried this locally I needed some additional updates: In In |
Contributor
Author
|
Ah, that makes sense, I am little confused on the need to change I've added a commit at any rate to include those changes. Thanks for verifying! |
Member
|
Yes - the new version of |
Contributor
Author
|
It looks like the PR in #54626 removes the |
Contributor
|
auto label is removed for flutter/engine/54629, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Member
|
I think this needs to be rebased in order to pass CI |
kevmoo
reviewed
Aug 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2024
…st versions to match (flutter/engine#54629)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2024
flutter/engine@86f269b...20b8a5c 2024-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from -XDS8eBA0Le-zCEfW... to 2fOjXGNxdSoRSGCL7... (flutter/engine#54635) 2024-08-20 58529443+srujzs@users.noreply.github.com Update package:js version constraints to ^0.7.0 and update test versions to match (flutter/engine#54629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…3741) flutter/engine@86f269b...20b8a5c 2024-08-20 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from -XDS8eBA0Le-zCEfW... to 2fOjXGNxdSoRSGCL7... (flutter/engine#54635) 2024-08-20 58529443+srujzs@users.noreply.github.com Update package:js version constraints to ^0.7.0 and update test versions to match (flutter/engine#54629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on
dart:jsand allows that library to be removed from dart2wasm. Also updatestestdependencies to work with the newpackage:jsconstraints.