Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Aug 19, 2024

Also removed two unused dev dependencies

Enables usage of Since in dart:js_interop

Also removed two unused dev dependencies

Enables usage of `Since` in dart:js_interop
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 19, 2024
@srujzs
Copy link
Contributor

srujzs commented Aug 19, 2024

cc @yjbanov I'm not sure why Kevin's attempt succeeded and mine didn't, but this is equivalent to #54590.

@kevmoo
Copy link
Contributor Author

kevmoo commented Aug 19, 2024

cc @yjbanov I'm not sure why Kevin's attempt succeeded and mine didn't, but this is equivalent to #54590.

magic

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2024
@auto-submit auto-submit bot merged commit 7dd71ff into main Aug 19, 2024
@auto-submit auto-submit bot deleted the update_sdk_for_web_ui branch August 19, 2024 22:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 20, 2024
flutter/engine@9d7e3a6...7dd71ff

2024-08-19 kevmoo@users.noreply.github.com web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626)
2024-08-19 chinmaygarde@google.com [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623)
2024-08-19 jacksongardner@google.com [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572)
2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 20, 2024
This reverts commit 7600900.

Reason for revert: flutter/engine#54626 has update the pubspecs for web_ui and web_sdk to include `3.6`.

Original change's description:
> Revert "[dart:js_interop] Add Since('3.6') annotations to new APIs"
>
> This reverts commit 14cf3b4.
>
> Reason for revert: web_ui uses some of these APIs, but the pubspec SDK version is not >= 3.6. Therefore, Flutter analyze fails, which would then result in a broken roll. Updating the pubspec versions leads to try bot failures (flutter/engine#54590) so for now, revert.
>
> Original change's description:
> > [dart:js_interop] Add Since('3.6') annotations to new APIs
> >
> > Closes #56484
> >
> > Change-Id: I9d3da568aafeccbb855892ea5c2ba647371170bc
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380900
> > Reviewed-by: Kevin Moore <kevmoo@google.com>
> > Reviewed-by: Leaf Petersen <leafp@google.com>
> > Reviewed-by: Sigmund Cherem <sigmund@google.com>
> > Commit-Queue: Srujan Gaddam <srujzs@google.com>
> > Reviewed-by: Martin Kustermann <kustermann@google.com>
>
> Change-Id: Idfb021c5744d83a8004259f9c8774945a2612efd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380967
> Reviewed-by: Leaf Petersen <leafp@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>

Change-Id: I5c37640e06456d270db2adfd70283456bde671ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381308
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…3733)

flutter/engine@9d7e3a6...7dd71ff

2024-08-19 kevmoo@users.noreply.github.com web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626)
2024-08-19 chinmaygarde@google.com [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623)
2024-08-19 jacksongardner@google.com [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572)
2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants