Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mbrase
Copy link
Contributor

@mbrase mbrase commented Jan 19, 2024

@jrwang jrwang assigned jrwang and mbrase and unassigned jrwang Jan 23, 2024
@jrwang jrwang self-requested a review January 23, 2024 16:06
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrwang jrwang merged commit b229878 into flutter:main Jan 23, 2024
@mbrase mbrase deleted the fidl_binding_deps branch January 23, 2024 16:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
flutter/engine@fd0335a...b229878

2024-01-23 mbrase@google.com Update buildroot for fidl_binding_deps() support in the Fuchsia SDK (flutter/engine#49909)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants