This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add fidl_binding_deps support from the Fuchsia SDK json files #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GN rules that parse the SDK json files previously only supported the `fidl_deps` field for determining which fidl dependencies to depend on. This change adds support for the newer `fidl_binding_deps` field, which contains information about what flavor of bindings are needed (hlcpp vs natural). Since our fidl GN targets always generate both hlcpp and natural bindings, we don't need to check the binding_type in the json file.
|
lgtm |
tarobins
approved these changes
Jan 11, 2024
mbrase
added a commit
to mbrase/flutter-engine
that referenced
this pull request
Jan 19, 2024
jrwang
pushed a commit
to flutter/engine
that referenced
this pull request
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GN rules that parse the SDK json files previously only supported the
fidl_depsfield for determining which fidl dependencies to depend on. This change adds support for the newerfidl_binding_depsfield, which contains information about what flavor of bindings are needed (hlcpp vs natural). Since our fidl GN targets always generate both hlcpp and natural bindings, we don't need to check the binding_type in the json file.