Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

tiled_texture.vert is identical to texture.vert, and position_uv is unused entirely.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams force-pushed the offload_uv_computation branch from 67f55a1 to aabf677 Compare May 30, 2023 15:01
@jonahwilliams jonahwilliams requested review from bdero and dnfield May 30, 2023 15:01
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 30, 2023

auto label is removed for flutter/engine, pr: 42416, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023
@auto-submit auto-submit bot merged commit a6d3124 into flutter:main May 30, 2023
@jonahwilliams jonahwilliams deleted the offload_uv_computation branch May 30, 2023 17:53
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2023
flutter/engine@5cd5b13...a6d3124

2023-05-30 jonahwilliams@google.com [Impeller] delete position_uv, tiled_texture vertex shaders. (flutter/engine#42416)
2023-05-30 bdero@google.com [Impeller] Bias towards sampling from lower mip levels (flutter/engine#42386)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants