This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Bias towards sampling from lower mip levels #42386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think this will be a pretty important quality improvement to track/retain, but it's a bit hard to capture with a sensible golden. Maybe a good way to get a human interpretable golden for this would be to render a scaled down rasterized VG image to a second pass, and then scale it way up with nearest sampling. There's not really a way to do that through the Aiks surface, so I'll need to backdoor something. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
flutter/engine@5cd5b13...a6d3124 2023-05-30 jonahwilliams@google.com [Impeller] delete position_uv, tiled_texture vertex shaders. (flutter/engine#42416) 2023-05-30 bdero@google.com [Impeller] Bias towards sampling from lower mip levels (flutter/engine#42386) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#127174.
Sets the same mip bias as Skia uses. Biases towards sampling from lower (larger) mip levels -- the tradeoff is a slightly higher cache miss rate in exchange for sharper/less blurry bilinear min-filtered images.
This makes scaled down images render identically between Impeller and Skia.
Original image
Impeller before
Impeller after
Skia