Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix preroll matrix snapping #36213

Merged
auto-submit merged 3 commits into from
Sep 16, 2022
Merged

Fix preroll matrix snapping #36213

auto-submit merged 3 commits into from
Sep 16, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 16, 2022 •
edited
Loading

Fixes additional cases where preroll did not always use pixel snapped CTM

@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2022
@auto-submit auto-submit bot merged commit 4ac405b into flutter:main Sep 16, 2022
@jonahwilliams jonahwilliams deleted the preroll_fixes branch September 16, 2022 20:37
jonahwilliams pushed a commit to jonahwilliams/engine that referenced this pull request Sep 16, 2022
Fix preroll matrix snapping (flutter#36213)
1692276
@jonahwilliams jonahwilliams mentioned this pull request Sep 16, 2022
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
4ac405b Fix preroll matrix snapping (flutter/engine#36213)
ac3ec62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
4ac405b Fix preroll matrix snapping (flutter/engine#36213)
7897b0e
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Fix preroll matrix snapping (flutter#36213)
e4bf7eb
itsjustkevin pushed a commit that referenced this pull request Sep 29, 2022
Dont snap in pre-roll (#36173) (#36181)
f23af29 
* Ensure pre-rolled opacity children see snapped matrix (#36173)

* Fix preroll matrix snapping (#36213)

* ++

* dont snap in preroll (#36239)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @dnfield