Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 15, 2022

Don't snap during pre-roll. This doesn't fix all of the issues, but does make things more consistent

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/36181

@jonahwilliams
Copy link
Contributor Author

Going to merge one more commit into this to pickup and additional case

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/36181

@jonahwilliams
Copy link
Contributor Author

Lets not merge this, there is something not right yet

@jonahwilliams jonahwilliams changed the title Ensure pre-rolled opacity children see snapped matrix (#36173) Dont snap in pre-roll (#36173) Sep 19, 2022
@jonahwilliams
Copy link
Contributor Author

now this is updated

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 4.
View them at https://flutter-engine-gold.skia.org/cl/github/36181

@chinmaygarde
Copy link
Contributor

@itsjustkevin I believe this needs to be cherry-picked.

@itsjustkevin itsjustkevin merged commit f23af29 into flutter:flutter-3.2-candidate.5 Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants