[web] Fix typo and add sampler3DRect in ShaderBuilder reserved words
#29997
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
cc @yjbanov |
yjbanov
left a comment
There was a problem hiding this comment.
LGTM.
Also, this may need a test exemption. I don't see how this assertion can be triggered from outside the engine code. Its only job is to make sure that our own shader code does not accidentally step on a reserved keyword. I'd also be fine with removing the assertion and just write our shader code carefully?
|
test-exempt: see above |
|
@xndcn thanks for your contribution! |
row_majoshould berow_majorsampler3DRectis also listed in GLSLangSpec.4.10 as keywords reserved for future useSorry I did not notice the last PR is closed, so I have to open a new one
#23797