Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@xndcn
Copy link
Contributor

@xndcn xndcn commented Jan 20, 2021

row_majo should be row_major
sampler3DRect is also listed in GLSLangSpec.4.10 as keywords reserved for future use

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jan 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@xndcn
Copy link
Contributor Author

xndcn commented Jan 20, 2021

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jan 20, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Jan 21, 2021
@yjbanov yjbanov self-requested a review June 24, 2021 22:09
@yjbanov yjbanov requested a review from ferhatb July 21, 2021 17:38
@yjbanov
Copy link
Contributor

yjbanov commented Aug 19, 2021

@xndcn Would you mind rebasing the PR to kick the infra?

@yjbanov
Copy link
Contributor

yjbanov commented Oct 13, 2021

Closing for now. Let's open a new PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants