Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Aug 25, 2021

Picks up a revert of a change from using python3 to vpython3 for exec
rules in gn. flutter/buildroot#507

Also sets Python runtime to python3 in gn.bat to match the revert to
python3 in the main gn wrapper in #28313

Issue: flutter/flutter#88719

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Picks up a revert of a change from using python3 to vpython3 for exec
rules in gn. flutter/buildroot#507

Also sets Python runtime to `python3` in `gn.bat` to match the revert to
`python3` in #28313

Issue: flutter/flutter#88719
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants