Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

This reverts commit 8b8c0c7.

We've seen flakiness with the following error on Windows since this
patch landed:

Using base prefix 'C:\\b\\s\\w\\ir\\cipd_bin_packages\\cpython3\\bin'
Traceback (most recent call last):
  File "virtualenv.py", line 2642, in <module>
    main()
  File "virtualenv.py", line 859, in main
    create_environment(
  File "virtualenv.py", line 1161, in create_environment
    install_python(home_dir, lib_dir, inc_dir, bin_dir, site_packages=site_packages, clear=clear, symlink=symlink)
  File "virtualenv.py", line 1450, in install_python
    copy_required_modules(home_dir, symlink)
  File "virtualenv.py", line 1342, in copy_required_modules
    copyfile(filename, dst_filename, symlink)
  File "virtualenv.py", line 425, in copyfile
    copy_file_or_folder(src, dest, symlink)
  File "virtualenv.py", line 400, in copy_file_or_folder
    shutil.copytree(src, dest, symlink)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython3\bin\lib\shutil.py", line 557, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "C:\b\s\w\ir\cipd_bin_packages\cpython3\bin\lib\shutil.py", line 513, in _copytree
    raise Error(errors)
shutil.Error: [('C:\\b\\s\\w\\ir\\cipd_bin_packages\\cpython3\\bin\\lib\\encodings\\__pycache__\\utf_8.cpython-38.pyc.2398892502592', 'C:\\b\\s\\w\\ir\\cache\\vpython\\51ae26\\lib\\encodings\\__pycache__\\utf_8.cpython-38.pyc.2398892502592', "[Errno 2] No such file or directory: 'C:\\\\b\\\\s\\\\w\\\\ir\\\\cipd_bin_packages\\\\cpython3\\\\bin\\\\lib\\\\encodings\\\\__pycache__\\\\utf_8.cpython-38.pyc.2398892502592'")]

Issue: flutter/flutter#88719

This reverts commit 8b8c0c7.

We've seen flakiness with the following error on Windows since this
patch landed:

```
Using base prefix 'C:\\b\\s\\w\\ir\\cipd_bin_packages\\cpython3\\bin'
Traceback (most recent call last):
  File "virtualenv.py", line 2642, in <module>
    main()
  File "virtualenv.py", line 859, in main
    create_environment(
  File "virtualenv.py", line 1161, in create_environment
    install_python(home_dir, lib_dir, inc_dir, bin_dir, site_packages=site_packages, clear=clear, symlink=symlink)
  File "virtualenv.py", line 1450, in install_python
    copy_required_modules(home_dir, symlink)
  File "virtualenv.py", line 1342, in copy_required_modules
    copyfile(filename, dst_filename, symlink)
  File "virtualenv.py", line 425, in copyfile
    copy_file_or_folder(src, dest, symlink)
  File "virtualenv.py", line 400, in copy_file_or_folder
    shutil.copytree(src, dest, symlink)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython3\bin\lib\shutil.py", line 557, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "C:\b\s\w\ir\cipd_bin_packages\cpython3\bin\lib\shutil.py", line 513, in _copytree
    raise Error(errors)
shutil.Error: [('C:\\b\\s\\w\\ir\\cipd_bin_packages\\cpython3\\bin\\lib\\encodings\\__pycache__\\utf_8.cpython-38.pyc.2398892502592', 'C:\\b\\s\\w\\ir\\cache\\vpython\\51ae26\\lib\\encodings\\__pycache__\\utf_8.cpython-38.pyc.2398892502592', "[Errno 2] No such file or directory: 'C:\\\\b\\\\s\\\\w\\\\ir\\\\cipd_bin_packages\\\\cpython3\\\\bin\\\\lib\\\\encodings\\\\__pycache__\\\\utf_8.cpython-38.pyc.2398892502592'")]
```

Issue: flutter/flutter#88719
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 6ef1bf7 into flutter:master Aug 25, 2021
@cbracken cbracken deleted the revert-vpython branch August 25, 2021 15:47
cbracken added a commit to flutter/engine that referenced this pull request Aug 26, 2021
Picks up a revert of a change from using python3 to vpython3 for exec
rules in gn. flutter/buildroot#507

Also sets Python runtime to `python3` in `gn.bat` to match the revert to
`python3` in #28313

Issue: flutter/flutter#88719
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants