Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

winuwp: Add multi-touch support #28067

Merged
fluttergithubbot merged 2 commits into from
Nov 18, 2021
Merged

winuwp: Add multi-touch support #28067

fluttergithubbot merged 2 commits into from
Nov 18, 2021

Conversation

@jnschulze
Copy link
Member

@jnschulze jnschulze commented Aug 13, 2021 •
edited
Loading

Now that multi touch is supported for Win32, it's time to implement it for UWP as well. This PR does so.

Fixes flutter/flutter#70201

Linked issues:

Tested with flutter_gallery.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 13, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Aug 13, 2021
@jnschulze
Copy link
Member Author

jnschulze commented Aug 13, 2021

/cc @clarkezone

@moko256 moko256 mentioned this pull request Aug 15, 2021
Merged
8 tasks
@clarkezone
Copy link

clarkezone commented Aug 23, 2021

Is there a test app i can try out to see this working?

@jnschulze
Copy link
Member Author

jnschulze commented Aug 23, 2021 •
edited
Loading

Is there a test app i can try out to see this working?

The flutter_gallery has an example called 2D transformations. This at least allows you to do some scaling using a pinch gesture.

@jnschulze jnschulze force-pushed the features/winuwp-multitouch branch from 31b0f2b to 225fc63 Compare August 31, 2021 13:00
@clarkezone
Copy link

clarkezone commented Sep 8, 2021

I will take a look in the next day or two (sorry for delay)

@clarkezone
Copy link

clarkezone commented Sep 26, 2021

I'm blocked currently due to inability to build the UWP target on my machine.

@cbracken
Copy link
Member

cbracken commented Sep 28, 2021

Overall this LGTM; @clarkezone any thoughts on ways we could test this?

cbracken
cbracken reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit, plus would like to get @clarkezone's thoughts on testing.

@clarkezone
Copy link

clarkezone commented Oct 10, 2021

Please can you update this to top of tree? I'm onblocked and standing by to test

@jnschulze jnschulze force-pushed the features/winuwp-multitouch branch from 11d49ee to 5ed5c2e Compare October 10, 2021 16:36
@jnschulze
Copy link
Member Author

jnschulze commented Oct 10, 2021

Please can you update this to top of tree? I'm onblocked and standing by to test

done.

clarkezone
clarkezone approved these changes Nov 13, 2021
View reviewed changes
Copy link

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:16
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 15, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde chinmaygarde changed the base branch from master to main November 18, 2021 21:01
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 18, 2021
@fluttergithubbot fluttergithubbot merged commit 1327b42 into flutter:main Nov 18, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2021
@engine-flutter-autoroll
1327b42 winuwp: Add multi-touch support (flutter/engine#28067)
65a648a
@jnschulze jnschulze deleted the features/winuwp-multitouch branch November 22, 2021 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cbracken cbracken cbracken left review comments

@clarkezone clarkezone clarkezone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement touch input for UWP embedding

5 participants

@jnschulze @clarkezone @cbracken @chinmaygarde @fluttergithubbot