Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Windows: Add multi-touch support #27863

Merged
fluttergithubbot merged 1 commit into from
Aug 13, 2021
Merged

Windows: Add multi-touch support #27863

fluttergithubbot merged 1 commit into from
Aug 13, 2021

Conversation

@jnschulze
Copy link
Member

@jnschulze jnschulze commented Aug 3, 2021

This PR implements multi-touch support for the Win32 platform.

I've tested this by running the Flutter Gallery (especially testing the "2D transformations" example to ensure that pinch gestures work now).
Besides, I've verified that the Listener widget handlers get invoked with correct event data.

It should be trivial to support multi-touch on UWP as well as it's just a matter of using the real pointer ID in flutter_windows_winuwp.cc as opposed to falling back to kDefaultPointerDeviceId.

Linked issues:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Aug 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 3, 2021
@jnschulze jnschulze force-pushed the features/windows-multitouch branch from 493472f to b95ed0c Compare August 3, 2021 16:12
@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 3, 2021
@jnschulze jnschulze force-pushed the features/windows-multitouch branch 2 times, most recently from 4590edd to c4e87d2 Compare August 3, 2021 17:40
@jnschulze
Copy link
Member Author

jnschulze commented Aug 3, 2021

@stuartmorgan @clarkezone

@clarkezone
Copy link

clarkezone commented Aug 5, 2021

Nice! I'll take a look at the weekend. Please make sure you test the the winuwp target continues to build and run.

@stuartmorgan-g stuartmorgan-g requested review from cbracken and clarkezone and removed request for cbracken August 5, 2021 15:58
clarkezone
clarkezone approved these changes Aug 8, 2021
View reviewed changes
Copy link

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Contributor

chinmaygarde commented Aug 12, 2021

This looks good to go. Can we rebase and commit this?

cbracken
cbracken approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo one nit. Thank you for implementing this!

@jnschulze jnschulze force-pushed the features/windows-multitouch branch from c4e87d2 to 0858988 Compare August 12, 2021 20:51
@jnschulze jnschulze force-pushed the features/windows-multitouch branch from 0858988 to da2ea3e Compare August 12, 2021 21:16
@jnschulze
Copy link
Member Author

jnschulze commented Aug 12, 2021

This looks good to go. Can we rebase and commit this?

Done.

@cbracken
Copy link
Member

cbracken commented Aug 13, 2021

Thanks -- looks great!

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 13, 2021
@cbracken
Copy link
Member

cbracken commented Aug 13, 2021

Related for cross-reference: flutter/flutter#70201

@fluttergithubbot fluttergithubbot merged commit 4b05f54 into flutter:master Aug 13, 2021
@jnschulze jnschulze mentioned this pull request Aug 13, 2021
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
4b05f54 Windows: Add multi-touch support (flutter/engine#27863)
138f19f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
4b05f54 Windows: Add multi-touch support (flutter/engine#27863)
39d5de0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
@engine-flutter-autoroll
4b05f54 Windows: Add multi-touch support (flutter/engine#27863)
c4f6f27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
@engine-flutter-autoroll
4b05f54 Windows: Add multi-touch support (flutter/engine#27863)
a4c77d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
@engine-flutter-autoroll
4b05f54 Windows: Add multi-touch support (flutter/engine#27863)
56563f8
@jnschulze jnschulze deleted the features/windows-multitouch branch January 3, 2022 09:18
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@jnschulze @filmil
Windows: Add multi-touch support (flutter#27863)
1d546a4
@loic-sharma loic-sharma mentioned this pull request Aug 18, 2025
Open
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cbracken cbracken cbracken approved these changes

@clarkezone clarkezone clarkezone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jnschulze @clarkezone @chinmaygarde @cbracken @fluttergithubbot