Add and use --quiet flag on the license checker#22485
Add and use --quiet flag on the license checker#22485fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
There was a problem hiding this comment.
Thanks. The presubmits are failing because the license checker itself was updated and the signature needs to be updated too.
a1d53bf to
e32ca05
Compare
|
@chinmaygarde I updated the tool signature to match, now running presubmits. |
e32ca05 to
d65c097
Compare
The license checker output looks particularly bad on CI by
default, as it prints thousands of lines of output for files
that do *not* need licensing attention.
This change introduces a flag '--quiet' which instructs the license
checker to print a dot per each examined file instead of the full
progress bar.
It also starts using the flag on CI immediately, since it seems
to reduce the visual clutter.
Manual invocations can get the verbose output like so:
env VERBOSE=1 ./ci/licenses.sh
Issue: flutter/flutter#70411
d65c097 to
ca55c1f
Compare
|
@chinmaygarde PTAL for merging --- the build seems broken now, but I had a successful run on this particular commit earlier. Thanks! |
|
@chinmaygarde PTAL for merge, all green now. |
Description
The license checker output looks particularly bad on CI by
default, as it prints thousands of lines of output for files
that do not need licensing attention.
This change introduces a flag '--quiet' which instructs the license
checker to print a dot per each examined file instead of the full
progress bar.
It also starts using the flag on CI immediately, since it seems
to reduce the visual clutter.
Manual invocations can get the verbose output like so:
Issue: flutter/flutter#70411
Related Issues
Tests
Tested manually.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.