Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Clean up deprecated EncodableValue code#20981

Merged
stuartmorgan-g merged 6 commits intoflutter:masterfrom
stuartmorgan-g:encodable-value-cleanup
Sep 11, 2020
Merged

Clean up deprecated EncodableValue code#20981
stuartmorgan-g merged 6 commits intoflutter:masterfrom
stuartmorgan-g:encodable-value-cleanup

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g commented Sep 3, 2020

Description

Removes the older pointer-based versions of APIs taking EncodableValues for which there are now reference-based versions.

Related Issues

Fixes flutter/flutter#63975
Part of flutter/flutter#52748

Tests

I added the following tests: None; only removes codepaths.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Copy Markdown
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@stuartmorgan-g stuartmorgan-g changed the title Clean up legacy/deprecated EncodableValue code Clean up deprecated EncodableValue code Sep 11, 2020
@stuartmorgan-g stuartmorgan-g merged commit 83cc923 into flutter:master Sep 11, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2020
@stuartmorgan-g stuartmorgan-g deleted the encodable-value-cleanup branch September 11, 2020 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change C++ MethodResult::Success and Error methods to use reference arguments

3 participants