Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds all the engine builders to the file used to validate tree status.#20642

Merged
godofredoc merged 1 commit intoflutter:masterfrom
godofredoc:update_list_prod
Aug 20, 2020
Merged

Adds all the engine builders to the file used to validate tree status.#20642
godofredoc merged 1 commit intoflutter:masterfrom
godofredoc:update_list_prod

Conversation

@godofredoc
Copy link
Contributor

Description

Builders are read from a json file to get their last builds using
buildbucket and calculate the tree status. Some builders were not being
used for the tree status validation allowing rollers to land changes
even though some builders were failing.

Related Issues

Bug:
flutter/flutter#64061

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Builders are read from a json file to get their last builds using
buildbucket and calculate the tree status. Some builders were not being
used for the tree status validation allowing rollers to land changes
even though some builders were failing.

Bug:
  flutter/flutter#64061
@godofredoc godofredoc merged commit 6caad8e into flutter:master Aug 20, 2020
@godofredoc godofredoc deleted the update_list_prod branch August 20, 2020 01:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants