This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds all the engine builders to the file used to validate tree status.#20642
Merged
godofredoc merged 1 commit intoflutter:masterfrom Aug 20, 2020
godofredoc:update_list_prod
Merged
Adds all the engine builders to the file used to validate tree status.#20642godofredoc merged 1 commit intoflutter:masterfrom godofredoc:update_list_prod
godofredoc merged 1 commit intoflutter:masterfrom
godofredoc:update_list_prod
Conversation
zanderso
approved these changes
Aug 19, 2020
Builders are read from a json file to get their last builds using buildbucket and calculate the tree status. Some builders were not being used for the tree status validation allowing rollers to land changes even though some builders were failing. Bug: flutter/flutter#64061
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builders are read from a json file to get their last builds using
buildbucket and calculate the tree status. Some builders were not being
used for the tree status validation allowing rollers to land changes
even though some builders were failing.
Related Issues
Bug:
flutter/flutter#64061
Tests
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.