Skip to content

[cocoon] LUCI-ENGINE GitHub check doesn't check previous builds if last build is pending #64061

@christopherfujino

Description

@christopherfujino

The LUCI-ENGINE check is defined in this file https://github.com/flutter/cocoon/blob/master/app_dart/lib/src/request_handlers/push_engine_status_to_github.dart#L54

It does not appear to be considering the case where the latest build for a builder is pending, but the previous build failed. The desired behavior in this situation is to return failure, and wait for a green build. https://github.com/flutter/cocoon/blob/master/app_dart/lib/src/request_handlers/push_engine_status_to_github.dart#L110

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions