Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Metal] On context loss with a paused texture source, preserve external pixel buffer. #18022

Merged
chinmaygarde merged 2 commits into from
Apr 29, 2020
Merged

[Metal] On context loss with a paused texture source, preserve external pixel buffer. #18022

chinmaygarde merged 2 commits into from
Apr 29, 2020

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Apr 29, 2020

Fixes flutter/flutter#55783
Requires follow-up flutter/flutter#55926

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Apr 29, 2020

cc @pcsosinski

@chinmaygarde chinmaygarde mentioned this pull request Apr 29, 2020
Closed
cbracken
cbracken approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

shell/platform/darwin/ios/ios_external_texture_metal.mm Outdated

void IOSExternalTextureMetal::OnGrContextDestroyed() {
// The image must be reset because it is tied to the onscreen context. But the pixel buffer that
// created the image is still around however. In case of context reacquisition, that last pixel
Copy link
Member

@cbracken cbracken Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber-nit: s/ however//

Copy link
Contributor Author

@chinmaygarde chinmaygarde Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@chinmaygarde chinmaygarde merged commit 2e738ee into flutter:master Apr 29, 2020
@chinmaygarde chinmaygarde deleted the paused_texture branch April 29, 2020 20:27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
9982e63 
…e external pixel buffer. (flutter/engine#18022)
This was referenced Apr 29, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
3db6f80 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
5f68ac0 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
ebb39b5 
…e external pixel buffer. (flutter/engine#18022)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
3e703ca 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
b8083bd 
…e external pixel buffer. (flutter/engine#18022)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
b09b7e1 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
49c1852 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
a8c79f9 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
0bd2bdd 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
f6d33a4 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
99ca6b9 
…e external pixel buffer. (flutter/engine#18022)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
aadf318 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
86b5dff 
…e external pixel buffer. (flutter/engine#18022)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
7164ef4 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
b9c35f7 
…e external pixel buffer. (flutter/engine#18022)
This was referenced May 1, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
37dff97 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
f433c0f 
…e external pixel buffer. (flutter/engine#18022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
9fef94f 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
5017c87 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
47d2991 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
5bcd735 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
80adf8b 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
03f9a8e 
…e external pixel buffer. (flutter/engine#18022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2020
@engine-flutter-autoroll
2e738ee [Metal] On context loss with a paused texture source, preserv…
efb896a 
…e external pixel buffer. (flutter/engine#18022)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cbracken cbracken cbracken approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Video player] Video disappears on iOS when any other native view comes up on top of the app

4 participants

@chinmaygarde @cbracken @jason-simmons @googlebot