Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Nov 15, 2019

Reverts #13859

This dart roll is causing failures in the engine->flutter roll.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please share the exact failures so we can figure out what's causing the rolls to fail.

@flar
Copy link
Contributor Author

flar commented Nov 15, 2019

The log can be found in this cirrus task rolling engine->flutter:

https://cirrus-ci.com/task/5177850163888128

@flar
Copy link
Contributor Author

flar commented Nov 15, 2019

Here is the compiler error:

[+1020 ms] Error compiling dartdevc module:flutter|lib/src/cupertino/action_sheet.ddc.js
           We're sorry, you've found a bug in our compiler.
           You can report this bug at:
               https://github.com/dart-lang/sdk/issues/labels/web-dev-compiler
           Please include the information below in your report, along with
           any other information that may help us track it down. Thanks!
           -------------------- %< --------------------
               dartdevc -k arguments: --dart-sdk-summary=/tmp/flutter sdk/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill --modules=amd --no-summarize -o packages/flutter/src/cupertino/action_sheet.ddc.js --source-map --summary=packages/meta/meta.ddc.dill=packages/meta/meta --summary=packages/typed_data/typed_buffers.ddc.dill=packages/typed_data/typed_buffers --summary=packages/flutter/src/foundation/_bitfield_web.ddc.dill=packages/flutter/src/foundation/_bitfield_web --summary=packages/flutter/foundation.ddc.dill=packages/flutter/foundation --summary=packages/vector_math/hash.ddc.dill=packages/vector_math/hash --summary=packages/vector_math/vector_math_64.ddc.dill=packages/vector_math/vector_math_64 --summary=packages/collection/src/utils.ddc.dill=packages/collection/src/utils --summary=packages/collection/src/algorithms.ddc.dill=packages/collection/src/algorithms --summary=packages/collection/src/iterable_zip.ddc.dill=packages/collection/src/iterable_zip --summary=packages/collection/src/comparators.ddc.dill=packages/collection/src/comparators --summary=packages/collection/src/priority_queue.ddc.dill=packages/collection/src/priority_queue --summary=packages/collection/src/canonicalized_map.ddc.dill=packages/collection/src/canonicalized_map --summary=packages/collection/collection.ddc.dill=packages/collection/collection --summary=packages/flutter/src/gestures/arena.ddc.dill=packages/flutter/src/gestures/arena --summary=packages/flutter/gestures.ddc.dill=packages/flutter/gestures --summary=packages/flutter/src/painting/_network_image_web.ddc.dill=packages/flutter/src/painting/_network_image_web --summary=packages/flutter/painting.ddc.dill=packages/flutter/painting --summary=packages/flutter/src/physics/clamped_simulation.ddc.dill=packages/flutter/src/physics/clamped_simulation --summary=packages/flutter/physics.ddc.dill=packages/flutter/physics --summary=packages/flutter/src/semantics/binding.ddc.dill=packages/flutter/src/semantics/binding --summary=packages/flutter/semantics.ddc.dill=packages/flutter/semantics --summary=packages/flutter/src/animation/animation.ddc.dill=packages/flutter/src/animation/animation --summary=packages/flutter/animation.ddc.dill=packages/flutter/animation --summary=packages/flutter/src/rendering/animated_size.ddc.dill=packages/flutter/src/rendering/animated_size --summary=packages/flutter/rendering.ddc.dill=packages/flutter/rendering --summary=packages/flutter/src/widgets/actions.ddc.dill=packages/flutter/src/widgets/actions --summary=packages/flutter/widgets.ddc.dill=packages/flutter/widgets --packages=file:///tmp/kernel_builder_ILJFVX/.packages --module-name=packages/flutter/src/cupertino/action_sheet --multi-root-scheme=org-dartlang-app --multi-root=. --track-widget-creation --inline-source-map --libraries-file=file:///tmp/flutter%20sdk/bin/cache/flutter_web_sdk/libraries.json --used-inputs-file=/tmp/ddk_builder_ZNGPBK/used_inputs.txt package:flutter/src/cupertino/context_menu.dart package:flutter/src/cupertino/text_field.dart package:flutter/src/cupertino/date_picker.dart package:flutter/src/cupertino/slider.dart package:flutter/src/cupertino/scrollbar.dart package:flutter/src/cupertino/interface_level.dart package:flutter/src/cupertino/icons.dart package:flutter/src/cupertino/page_scaffold.dart package:flutter/src/cupertino/segmented_control.dart package:flutter/src/cupertino/theme.dart package:flutter/src/cupertino/text_selection.dart package:flutter/src/cupertino/tab_view.dart package:flutter/src/cupertino/route.dart package:flutter/src/cupertino/action_sheet.dart package:flutter/src/cupertino/switch.dart package:flutter/src/cupertino/localizations.dart package:flutter/src/cupertino/nav_bar.dart package:flutter/src/cupertino/bottom_tab_bar.dart package:flutter/src/cupertino/icon_theme_data.dart package:flutter/src/cupertino/refresh.dart package:flutter/src/cupertino/button.dart package:flutter/src/cupertino/thumb_painter.dart package:flutter/src/cupertino/context_menu_action.dart package:flutter/src/cupertino/colors.dart package:flutter/src/cupertino/app.dart package:flutter/src/cupertino/text_theme.dart package:flutter/src/cupertino/constants.dart package:flutter/src/cupertino/dialog.dart package:flutter/src/cupertino/activity_indicator.dart package:flutter/src/cupertino/picker.dart package:flutter/src/cupertino/tab_scaffold.dart package:flutter/src/cupertino/sliding_segmented_control.dart

@flar
Copy link
Contributor Author

flar commented Nov 15, 2019

This commit will allegedly fix it if we can roll to that instead: dart-lang/sdk@ef5fb7d

@flar flar closed this Nov 15, 2019
@flar flar reopened this Nov 15, 2019
@flar flar merged commit 90a6054 into master Nov 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
flar pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2019
* 174e0e9 Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter/engine#13859)

* 33d997c Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter/engine#13861)

* b4899d9 Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter/engine#13862)

* f456423 RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812)

* 6bab64e Fix test to account for pixel ratio transformations being framework responsibility. (flutter/engine#13850)

* 5b10fa3 Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter/engine#13857)

* 97df087 [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter/engine#13865)

* 0832dfd [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter/engine#13864)

* 141dc785d Roll src/third_party/skia e57ca4931952..c1c4634dcb07 (15 commits) (flutter/engine#13866)

* 90a6054 Revert "Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (#13859)" (flutter/engine#13867)
@tvolkert tvolkert deleted the revert-13859-dart-sdk-roll-2019-11-14 branch December 4, 2019 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants