Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll
Copy link
Contributor

https://skia.googlesource.com/skia.git/+log/e57ca4931952..c1c4634dcb07

git log e57ca49..c1c4634 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 reed@google.com add some api helpers (extracted from different CL)
2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-14 benjaminwagner@google.com Use Clang for CMake build
2019-11-14 herb@google.com Hoist regenGlyphs out of per glyph loop
2019-11-14 rmistry@google.com Specify only luci buckets instead of hardcoding trybot names
2019-11-14 ahujabharat93@gmail.com Issue- >Skia tiled bitmap rendering is too slow when tildmodeX is not same as tileModeY. Reason-> Skia uses general-purpose pipeline in this case instead of more optimized faster pipeline. Faster pipeline code was available in older versions of Skia and used to work fine but we removed faster pipeline code to consolidate the code. As discussed offline for us in the office we have significant scenarios running on software, so maintaining software performance is very important for us thus I am bringing this fast path back. To make this work I didn't have to do much, everything was already available, I just had to modify MatirxProcs to accept tilemodex and tilemodeY as parameters and define and configure SkBitmapProcState::MatrixProc GeneralProcs. I have also limited this change to ARM devices
2019-11-14 jvanverth@google.com Reduce scaling of large SDF glyphs on Mac.
2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-14 csmartdalton@google.com Revert "Reland "Reland "Implement sample mask and sample locations support in Vulkan"""
2019-11-14 kjlubick@google.com [canvaskit] Expose a few more methods
2019-11-14 fmalita@chromium.org [skottie] One-node camera support
2019-11-14 robertphillips@google.com Respect max index buffer sizes in GrFillRectOp::MakeSet
2019-11-14 csmartdalton@google.com Reland "Reland "Implement sample mask and sample locations support in Vulkan""
2019-11-14 nigeltao@google.com Reset SkWuffsCodec frame-count decoder less often
2019-11-14 bsalomon@google.com Fixed sampling non-SkSL FPs with coordinates

Created with:
gclient setdep -r src/third_party/skia@c1c4634dcb07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com

https://skia.googlesource.com/skia.git/+log/e57ca4931952..c1c4634dcb07

git log e57ca49..c1c4634 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 reed@google.com add some api helpers (extracted from different CL)
2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-14 benjaminwagner@google.com Use Clang for CMake build
2019-11-14 herb@google.com Hoist regenGlyphs out of per glyph loop
2019-11-14 rmistry@google.com Specify only luci buckets instead of hardcoding trybot names
2019-11-14 ahujabharat93@gmail.com Issue- >Skia tiled bitmap rendering is too slow when tildmodeX is not same as tileModeY. Reason-> Skia uses general-purpose pipeline in this case instead of more optimized faster pipeline. Faster pipeline code was available in older versions of Skia and used to work fine but we removed faster pipeline code to consolidate the code. As discussed offline for us in the office we have significant scenarios running on software, so maintaining software performance is very important for us thus I am bringing this fast path back. To make this work I didn't have to do much, everything was already available, I just had to modify MatirxProcs to accept tilemodex and tilemodeY as parameters and define and configure SkBitmapProcState::MatrixProc GeneralProcs. I have also limited this change to ARM devices
2019-11-14 jvanverth@google.com Reduce scaling of large SDF glyphs on Mac.
2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-14 csmartdalton@google.com Revert "Reland "Reland "Implement sample mask and sample locations support in Vulkan"""
2019-11-14 kjlubick@google.com [canvaskit] Expose a few more methods
2019-11-14 fmalita@chromium.org [skottie] One-node camera support
2019-11-14 robertphillips@google.com Respect max index buffer sizes in GrFillRectOp::MakeSet
2019-11-14 csmartdalton@google.com Reland "Reland "Implement sample mask and sample locations support in Vulkan""
2019-11-14 nigeltao@google.com Reset SkWuffsCodec frame-count decoder less often
2019-11-14 bsalomon@google.com Fixed sampling non-SkSL FPs with coordinates

Created with:
  gclient setdep -r src/third_party/skia@c1c4634dcb07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
@skia-flutter-autoroll
Copy link
Contributor Author

Auto-roller completed checks. About to merge.

@skia-flutter-autoroll skia-flutter-autoroll merged commit 141dc78 into flutter:master Nov 14, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2019
flar pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2019
* 174e0e9 Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter/engine#13859)

* 33d997c Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter/engine#13861)

* b4899d9 Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter/engine#13862)

* f456423 RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812)

* 6bab64e Fix test to account for pixel ratio transformations being framework responsibility. (flutter/engine#13850)

* 5b10fa3 Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter/engine#13857)

* 97df087 [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter/engine#13865)

* 0832dfd [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter/engine#13864)

* 141dc785d Roll src/third_party/skia e57ca4931952..c1c4634dcb07 (15 commits) (flutter/engine#13866)

* 90a6054 Revert "Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (#13859)" (flutter/engine#13867)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants