Update canvaskit backend #12318

harryterkelsen · 2019-09-17T17:10:44Z

Improve font handling by trying to load a "normal" font face instead of using the first face matching the family.
Implement Vertices and drawVertices

- Improve font handling by trying to load a "normal" font face instead of using the first face matching the family. - Implement Vertices and drawVertices

yjbanov · 2019-09-17T17:20:26Z

lib/web_ui/lib/src/engine/compositor/fonts.dart

+      return js.JsObject(canvasKit['SkFont'], <dynamic>[null, size]);
    }
-    final js.JsObject skTypeface = _registeredTypefaces[family].values.first;
+    //final js.JsObject skTypeface = _registeredTypefaces[family].values.first;


Still need this line?

yjbanov · 2019-09-17T17:22:42Z

lib/web_ui/lib/src/engine/compositor/fonts.dart

+    js.JsObject skTypeface;
+
+    for (MapEntry<Map<String, String>, js.JsObject> entry
+        in typefaces.entries) {


nit: forEach might be faster here because it doesn't need to allocate a MapEntry on each iteration.

forEach doesn't allow you to terminate iteration early, keeping the for-loop for now

yjbanov · 2019-09-17T17:23:09Z

lib/web_ui/lib/src/engine/compositor/initialization.dart

 /// EXPERIMENTAL: Enable the Skia-based rendering backend.
 const bool experimentalUseSkia =
-    bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: false);
+    bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: true);


How confident are we about the Skia backend?

yjbanov · 2019-09-17T17:27:35Z

lib/web_ui/lib/src/engine/compositor/vertices.dart

+    js.JsArray<js.JsArray<double>> encodedPositions =
+        js.JsArray<js.JsArray<double>>();
+    encodedPositions.length = positions.length ~/ 2;
+    for (int i = 0; i < positions.length; i += 2) {}


What does this do?

leftover code, deleted

git@github.com:flutter/engine.git/compare/63873d9f421f...d1692d4 git log 63873d9..d1692d4 --no-merges --oneline 2019-09-17 hterkelsen@users.noreply.github.com Update canvaskit backend (flutter/engine#12318) 2019-09-17 mouad.debbar@gmail.com README for the felt tool (flutter/engine#12323) 2019-09-17 jason-simmons@users.noreply.github.com Fix continuous event polling in the GLFW event loop (flutter/engine#12320) 2019-09-17 15365765+rafern@users.noreply.github.com Tests for #11283 (flutter/engine#12322) 2019-09-17 ditman@gmail.com Improve check to render (or not) a DRRect when inner falls outside of outer on RecordingCanvas (flutter/engine#12229) 2019-09-17 bkonyi@google.com Roll src/third_party/dart dd1969a43a..7505b3a5f0 (39 commits) 2019-09-17 30870216+gaaclarke@users.noreply.github.com Channel buffers (flutter/engine#12167) 2019-09-17 xster@google.com Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible (flutter/engine#12128) 2019-09-17 stuartmorgan@google.com Adds PluginRegistry to the C++ client wrapper API (flutter/engine#12287) 2019-09-17 liyuqian@google.com Add "type" to getDisplayRefreshRate protocol (flutter/engine#12319) 2019-09-17 mouad.debbar@gmail.com Add a build command to felt (flutter/engine#12303) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia df432d5efb70..d545bfbb94ca (1 commits) (flutter/engine#12316) 2019-09-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-... (flutter/engine#12315) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia f8486f2c5fb6..df432d5efb70 (1 commits) (flutter/engine#12313) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia b47704b0bd34..f8486f2c5fb6 (2 commits) (flutter/engine#12312) 2019-09-16 jason-simmons@users.noreply.github.com Fix the declaration of setSystemGestureExclusionRects to match the PlatformMessageHandler interface (flutter/engine#12306) 2019-09-16 gw280@google.com Manage resource and onscreen contexts using separate IOSGLContext objects (flutter/engine#12277) 2019-09-16 goderbauer@google.com Cleanup in web_ui (flutter/engine#12307) 2019-09-16 30870216+gaaclarke@users.noreply.github.com Made flutter startup faster by allowing initialization to be parallelized (flutter/engine#10182) 2019-09-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia c22498502cda..b47704b0bd34 (16 commits) (flutter/engine#12304) 2019-09-16 jonahwilliams@google.com Include firefox in check to quote font families (flutter/engine#12288) 2019-09-16 bkonyi@google.com Roll src/third_party/dart 7799f424f4..dd1969a43a (2 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/63873d9f421f...d1692d4 git log 63873d9..d1692d4 --no-merges --oneline 2019-09-17 hterkelsen@users.noreply.github.com Update canvaskit backend (flutter/engine#12318) 2019-09-17 mouad.debbar@gmail.com README for the felt tool (flutter/engine#12323) 2019-09-17 jason-simmons@users.noreply.github.com Fix continuous event polling in the GLFW event loop (flutter/engine#12320) 2019-09-17 15365765+rafern@users.noreply.github.com Tests for flutter#11283 (flutter/engine#12322) 2019-09-17 ditman@gmail.com Improve check to render (or not) a DRRect when inner falls outside of outer on RecordingCanvas (flutter/engine#12229) 2019-09-17 bkonyi@google.com Roll src/third_party/dart dd1969a43a..7505b3a5f0 (39 commits) 2019-09-17 30870216+gaaclarke@users.noreply.github.com Channel buffers (flutter/engine#12167) 2019-09-17 xster@google.com Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible (flutter/engine#12128) 2019-09-17 stuartmorgan@google.com Adds PluginRegistry to the C++ client wrapper API (flutter/engine#12287) 2019-09-17 liyuqian@google.com Add "type" to getDisplayRefreshRate protocol (flutter/engine#12319) 2019-09-17 mouad.debbar@gmail.com Add a build command to felt (flutter/engine#12303) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia df432d5efb70..d545bfbb94ca (1 commits) (flutter/engine#12316) 2019-09-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-... (flutter/engine#12315) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia f8486f2c5fb6..df432d5efb70 (1 commits) (flutter/engine#12313) 2019-09-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia b47704b0bd34..f8486f2c5fb6 (2 commits) (flutter/engine#12312) 2019-09-16 jason-simmons@users.noreply.github.com Fix the declaration of setSystemGestureExclusionRects to match the PlatformMessageHandler interface (flutter/engine#12306) 2019-09-16 gw280@google.com Manage resource and onscreen contexts using separate IOSGLContext objects (flutter/engine#12277) 2019-09-16 goderbauer@google.com Cleanup in web_ui (flutter/engine#12307) 2019-09-16 30870216+gaaclarke@users.noreply.github.com Made flutter startup faster by allowing initialization to be parallelized (flutter/engine#10182) 2019-09-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia c22498502cda..b47704b0bd34 (16 commits) (flutter/engine#12304) 2019-09-16 jonahwilliams@google.com Include firefox in check to quote font families (flutter/engine#12288) 2019-09-16 bkonyi@google.com Roll src/third_party/dart 7799f424f4..dd1969a43a (2 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

harryterkelsen added 2 commits September 16, 2019 15:12

Improve the CanvasKit backend for Flutter Web

977a30e

- Improve font handling by trying to load a "normal" font face instead of using the first face matching the family. - Implement Vertices and drawVertices

Merge branch 'master' into update-canvaskit-backend

bf09631

harryterkelsen requested a review from yjbanov September 17, 2019 17:10

googlebot added the cla: yes label Sep 17, 2019

harryterkelsen added 2 commits September 17, 2019 10:23

Add license header to vertices.dart

fa62ed0

Remove unused 'encodedPositions'

992b679

yjbanov approved these changes Sep 17, 2019

View reviewed changes

harryterkelsen added 2 commits September 17, 2019 13:16

Delete commented old code. Don't use Skia by default

510e382

Add vertices.dart to licenses file

ea5cf41

harryterkelsen merged commit d1692d4 into flutter:master Sep 17, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 17, 2019

d1692d4 Update canvaskit backend (flutter/engine#12318)

3fbb066

engine-flutter-autoroll mentioned this pull request Sep 17, 2019

Roll engine 63873d9f421f..d1692d4cc703 (22 commits) flutter/flutter#40717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update canvaskit backend #12318

Update canvaskit backend #12318

Uh oh!

harryterkelsen commented Sep 17, 2019

Uh oh!

yjbanov Sep 17, 2019

Uh oh!

harryterkelsen Sep 17, 2019

Uh oh!

yjbanov Sep 17, 2019

Uh oh!

harryterkelsen Sep 17, 2019

Uh oh!

yjbanov Sep 17, 2019

Uh oh!

harryterkelsen Sep 17, 2019

Uh oh!

yjbanov Sep 17, 2019

Uh oh!

harryterkelsen Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update canvaskit backend #12318

Update canvaskit backend #12318

Uh oh!

Conversation

harryterkelsen commented Sep 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants