This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Finish plumbing message responses on method channels #11877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Sep 4, 2019
| MethodCall<T> method_call(method, std::move(arguments)); | ||
| std::unique_ptr<std::vector<uint8_t>> message = | ||
| codec_->EncodeMethodCall(method_call); | ||
| messenger_->Send(name_, message->data(), message->size()); |
Contributor
There was a problem hiding this comment.
This implementation should be replaced with calling the new method with a null reply to avoid duplicated code.
| std::cerr << "Calling BinaryMessengerImpl::Send expecting a reply, but the " | ||
| "callback is null.\n"; | ||
| FlutterDesktopMessengerSend(messenger_, channel.c_str(), message, | ||
| message_size); |
Contributor
There was a problem hiding this comment.
Ah, I didn't realize we were checking for null here. But I think this change is probably the right approach.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 5, 2019
git@github.com:flutter/engine.git/compare/cd920398e40e...edee1fe git log cd92039..edee1fe --no-merges --oneline 2019-09-05 egarciad@google.com Add @keep annotation (flutter/engine#11893) 2019-09-05 bkonyi@google.com Roll src/third_party/dart d0218d4771..be66176534 (11 commits) 2019-09-05 shihaohong@google.com Incorporate View.setSystemGestureExclusionRects code review feedback from #11441 (flutter/engine#11804) 2019-09-05 naifu.guan@gmail.com Support build windows release/profile embedding builds (flutter/engine#11475) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia e784f75beb20..adecf4b6d5fe (6 commits) (flutter/engine#11900) 2019-09-05 xster@google.com remove extra redundant channels setup in iOS embedding engine (flutter/engine#11886) 2019-09-05 liyuqian@google.com Revert "Add a BroadcastStream to FrameTiming (#11041)" (flutter/engine#11841) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from OmqaW... to Z7PSg... (flutter/engine#11898) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from S-f_C... to -AQkJ... (flutter/engine#11897) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia b0e2347fedfc..e784f75beb20 (1 commits) (flutter/engine#11896) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 6eed35b60d..d0218d4771 (5 commits) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 97218352addb..b0e2347fedfc (4 commits) (flutter/engine#11894) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 67bb2b7819..6eed35b60d (18 commits) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LKWtB... to OmqaW... (flutter/engine#11891) 2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from m-hNV... to S-f_C... (flutter/engine#11889) 2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 166751ef578a..97218352addb (1 commits) (flutter/engine#11888) 2019-09-05 bkonyi@google.com Roll src/third_party/dart 08132661a6..67bb2b7819 (4 commits) 2019-09-04 franciscojma86@gmail.com Finish plumbing message responses on method channels (flutter/engine#11877) 2019-09-04 bkonyi@google.com Roll src/third_party/dart c3db2e3ee0..08132661a6 (2 commits) 2019-09-04 james@clarkezone.net [Windows] Address #36422 by adding a context for async resource uploading (flutter/engine#11828) 2019-09-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia e7366841663b..166751ef578a (7 commits) (flutter/engine#11881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC franciscojma@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#38977
Tested manually by logging replies from the text input plugins