Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Sep 3, 2019

This reverts commit e97ed36.

Reason for revert: Stream is considered a bad API: #11041 (comment)

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 4243324 into flutter:master Sep 5, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 5, 2019
git@github.com:flutter/engine.git/compare/cd920398e40e...edee1fe

git log cd92039..edee1fe --no-merges --oneline
2019-09-05 egarciad@google.com Add @keep annotation (flutter/engine#11893)
2019-09-05 bkonyi@google.com Roll src/third_party/dart d0218d4771..be66176534 (11 commits)
2019-09-05 shihaohong@google.com Incorporate View.setSystemGestureExclusionRects code review feedback from #11441 (flutter/engine#11804)
2019-09-05 naifu.guan@gmail.com Support build windows release/profile embedding builds (flutter/engine#11475)
2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia e784f75beb20..adecf4b6d5fe (6 commits) (flutter/engine#11900)
2019-09-05 xster@google.com remove extra redundant channels setup in iOS embedding engine (flutter/engine#11886)
2019-09-05 liyuqian@google.com Revert "Add a BroadcastStream to FrameTiming (#11041)" (flutter/engine#11841)
2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from OmqaW... to Z7PSg... (flutter/engine#11898)
2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from S-f_C... to -AQkJ... (flutter/engine#11897)
2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia b0e2347fedfc..e784f75beb20 (1 commits) (flutter/engine#11896)
2019-09-05 bkonyi@google.com Roll src/third_party/dart 6eed35b60d..d0218d4771 (5 commits)
2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 97218352addb..b0e2347fedfc (4 commits) (flutter/engine#11894)
2019-09-05 bkonyi@google.com Roll src/third_party/dart 67bb2b7819..6eed35b60d (18 commits)
2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LKWtB... to OmqaW... (flutter/engine#11891)
2019-09-05 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from m-hNV... to S-f_C... (flutter/engine#11889)
2019-09-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 166751ef578a..97218352addb (1 commits) (flutter/engine#11888)
2019-09-05 bkonyi@google.com Roll src/third_party/dart 08132661a6..67bb2b7819 (4 commits)
2019-09-04 franciscojma86@gmail.com Finish plumbing message responses on method channels (flutter/engine#11877)
2019-09-04 bkonyi@google.com Roll src/third_party/dart c3db2e3ee0..08132661a6 (2 commits)
2019-09-04 james@clarkezone.net [Windows] Address #36422 by adding a context for async resource uploading (flutter/engine#11828)
2019-09-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia e7366841663b..166751ef578a (7 commits) (flutter/engine#11881)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@liyuqian liyuqian deleted the revert branch September 10, 2019 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants