This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add check to enable metal for import #11537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Was this causing a compilation error or something somewhere? |
chinmaygarde
approved these changes
Aug 27, 2019
Contributor
|
Ohh for the google roll probably. I get it now. LGTM. |
Contributor
Author
|
@dnfield You're right. Its for the google roll! This fixes build errors and this PR adds it upstream. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 28, 2019
git@github.com:flutter/engine.git/compare/f93b9cbff143...180adcb git log f93b9cb..180adcb --no-merges --oneline 2019-08-28 jonahwilliams@google.com make engine, ui, and sdk rewriter inputs of dill construction (flutter/engine#11554) 2019-08-28 dnfield@google.com Make Skia cache size channel respond with a value (flutter/engine#11550) 2019-08-27 bkonyi@google.com Roll src/third_party/dart f17d0563fa..2bc0f49c00 (10 commits) 2019-08-27 bmparr@google.com Add check to enable metal for import (flutter/engine#11537) 2019-08-27 pylaligand@google.com Update label of Fuchsia FIDL targets. (flutter/engine#11514) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conditional import to use metal.
Related PR: #11070