Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@pylaligand
Copy link
Contributor

No description provided.

@abarth
Copy link
Contributor

abarth commented Aug 27, 2019

LGTM, but you should get approval from folks who work on this code nowadays.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM stamp from a Japanese personal seal

@pylaligand pylaligand merged commit aba340a into flutter:master Aug 27, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 28, 2019
git@github.com:flutter/engine.git/compare/f93b9cbff143...180adcb

git log f93b9cb..180adcb --no-merges --oneline
2019-08-28 jonahwilliams@google.com make engine, ui, and sdk rewriter inputs of dill construction (flutter/engine#11554)
2019-08-28 dnfield@google.com Make Skia cache size channel respond with a value (flutter/engine#11550)
2019-08-27 bkonyi@google.com Roll src/third_party/dart f17d0563fa..2bc0f49c00 (10 commits)
2019-08-27 bmparr@google.com Add check to enable metal for import (flutter/engine#11537)
2019-08-27 pylaligand@google.com Update label of Fuchsia FIDL targets. (flutter/engine#11514)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants