Use the authenticated client when requested PR files #4191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently hitting free quota; which fails and falls back to "build everything"
matanlurey
approved these changes
Jan 28, 2025
Contributor
matanlurey
left a comment
There was a problem hiding this comment.
Seems reasonable.
(I find it weird that a config has a factory method but I won't start arguing now)
4 tasks
This was referenced Mar 22, 2025
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 22, 2025
…s. (#4368) Closes flutter/flutter#161462. It turns out @jtmcdole had _accidentally_ fixes fixed by using our `GithubService` wrapper while refactoring, meaning `PaginationHelper` has been used this _entire_ time, and we have been getting the full list of files (since #4191 at least), so this can actually be lifted. In addition, we can just gate the optimization on a specific release branch (to speed up beta/new stables).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hitting free quota; which fails and falls back to "build everything"
There wasn't any tests for
GithubApiGetFilesChanged, but we'd only verify one api was called over another.