Raise limit to 1000 framework-only files and modern release branches.
#4368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
reviewed
Mar 22, 2025
Member
jtmcdole
left a comment
There was a problem hiding this comment.
There still is a API limit right? 1000 files max with pagination?
Contributor
Author
|
Ah:
Ok, we can limit to 1000 files just in case. |
05226c4 to
56cc05f
Compare
30 framework-only files and modern release branches.1000 framework-only files and modern release branches.
Member
Yeah, just got on my PC to check it; looks like that + we could be asking for 100 files If we just get the PullRequest, it should tell us "changed_files": {
"type": "integer",
"examples": [
5
]
} |
jtmcdole
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#161462.
It turns out @jtmcdole had accidentally fixes fixed by using our
GithubServicewrapper while refactoring, meaningPaginationHelperhas been used this entire time, and we have been getting the full list of files (since #4191 at least), so this can actually be lifted.In addition, we can just gate the optimization on a specific release branch (to speed up beta/new stables).