Make Test.kt files count as tests for the purpose of calculating if a PR has tests
#4162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba4d57d to
d7a98c4
Compare
9 tasks
stuartmorgan-g
approved these changes
Jan 18, 2025
app_dart/lib/src/request_handlers/github/webhook_subscription.dart
Outdated
Show resolved
Hide resolved
reidbaker
reviewed
Jan 21, 2025
app_dart/lib/src/request_handlers/github/webhook_subscription.dart
Outdated
Show resolved
Hide resolved
| filename.contains('android/src/test/') || | ||
| filename.contains('androidTest/') || | ||
| // Kotlin source tests, used in the Flutter Gradle Plugin. | ||
| filename.contains('Test.kt') || |
Contributor
There was a problem hiding this comment.
Please also add an entry into app_dart/test/request_handlers/github/webhook_subscription_test.dart so that this does not regress.
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…DME (#4169) Follow up to #4162. The first PR was wrong - it modified the logic that is used to handle packages PRs, not framework PRs. This PR fixes that, adds a test, and also modifies the README to add a missing step that I found in flutter/flutter#129651, which originally blocked me from running the tests locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
Test.ktfiles count as tests for the purpose of calculating if a PR has tests.Context: flutter/flutter#161835
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.