Fix exemption for flutter tool Kotlin tests, add test, and update README #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Jan 21, 2025
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
Best I can tell all of webhook_subscription.dart is formatting. If so consider reverting in this pr.
45417ed to
37d7ea0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Test.kt file present in the PR
Member
Author
|
Re requesting your review @reidbaker - the request for a test actually found a bug, so the PR is no longer just a test. |
reidbaker
approved these changes
Jan 22, 2025
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
I love when tests catch bugs
stuartmorgan-g
approved these changes
Jan 22, 2025
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM! Sorry I didn't catch the lack of test when reviewing the first PR; I should have, since I've written tests changes in this file plenty of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4162.
The first PR was wrong - it modified the logic that is used to handle packages PRs, not framework PRs. This PR fixes that, adds a test, and also modifies the README to add a missing step that I found in flutter/flutter#129651, which originally blocked me from running the tests locally.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.