This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Ignore file case mismatches for Windows goma builds #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 11, 2020
| # goma compilation doesn't preserve file case, so don't warn about | ||
| # case-mismatches. | ||
| default_warning_flags += [ | ||
| "-Wno-nonportable-include-path", |
Contributor
There was a problem hiding this comment.
On second thought, why not just replace add this unconditionally on Windows? It feels odd that the TU will get different flags based on whether or not goma is used. You call though.
Contributor
Author
There was a problem hiding this comment.
The issue is specific to goma AFAICT, and leaving it this way means we'll still get warnings locally for legitimate case mismatches. It seems like it would be a shame to have no way of getting warnings for things that are legitimately incorrect.
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Apparently goma builds don't preserve file case, causing lots of warnings about non-portable include paths. This eliminates ~249,000 warnings for the Windows Host Engine builds, making the log file several orders of magnitude smaller and making it usable when opened in the browser. Addresses most of flutter/flutter#59199
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently goma builds don't preserve file case, causing lots of warnings about non-portable include paths. This eliminates ~249,000 warnings for the Windows Host Engine builds, making the log file several orders of magnitude smaller and making it usable when opened in the browser.
Addresses most of flutter/flutter#59199