Skip to content

Fix or suppress remaining Windows engine warnings #59199

@stuartmorgan-g

Description

@stuartmorgan-g

The Windows host engine build's stdout from a bot is currently about 125MB, and 1.6 million lines, because it has 250,000 warnings. This makes looking for errors—or even just loading it—quite painful.

Main categories:

  • ~249,000: specified path differs in case from file name on disk This suggests this is a goma issue, and we just need to suppress the warning. Fixed
  • ~900: The POSIX name for this item is deprecated. Almost all from Dart, mostly strdup. The fix is either to suppress them, or wrap them, as discussed in https://dart-review.googlesource.com/c/sdk/+/134781 Fixed
  • ~150: no newline at end of file. All (or very close to all) from ANGLE. Ideally we should just fix that upstream. Fixed.

After that it's just about 20 miscellaneous warnings, mostly conversion warnings in Dart and ANGLE. It would be nice to fix them, but 20 warnings would be a lot better than 250,000

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specifically

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions